build: reduce hardcoding and inconsistencies #6230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce TARNAME hardcoding.
kmk3
force-pushed
the
build-reduce-inconsistencies
branch
from
3309314 to
730d1f2
Compare
To reduce TARNAME hardcoding. Added on commit 6a89ab0 ("ci: run firejail --version after build/install", 2022-05-16) / PR netblue30#5148.
To reduce hardcoding. Note that this reduces duplication but the value is still hardcoded in the job; it is not sourced from TARNAME in config.mk.
Sync the build and build-clang jobs.
test/ also contains source code and cppcheck checks it:
$ make cppcheck | grep 'Checking test/'
Checking test/appimage/main.c ...
Checking test/chroot/unchroot.c ...
Checking test/filters/namespaces.c ...
Checking test/seccomp-extra/memwrexe.c ...
So make sure that it is included in the CI trigger paths.
To make it easier to compare and edit the main apt-based jobs in .gitlab-ci.yml.
Format it for readability and update the descriptions to match the current jobs.
Line-wrap the file and sort ./configure arguments.
Currently the number of make jobs used for the default build target are hardcoded and the value used varies across files. For consistency (and potentially better performance), use `make -j "$(nproc)"` everywhere that `make -j` is currently used. Kind of relates to commit 500d8f2 ("ci: run make in parallel where applicable", 2023-08-14) / PR netblue30#5960.
For consistency and to make it clearer where jobs differ (for example, to see where `--enable-analyzer` is used). Changes: * Always use --prefix=/usr and --enable-fatal-warnings (except in the Alpine job due to current warnings; see netblue30#6224) * Use the same argument order Note: mkdeb.sh and platform/rpm/mkrpm.sh already pass `--prefix=/usr` to ./configure.
kmk3
force-pushed
the
build-reduce-inconsistencies
branch
from
730d1f2 to
2301ab2
Compare
|
merged, let's try it! |
kmk3
added a commit
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
Relates to #5148 #5960 #6224.
This is a follow-up to #6222.