Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: allow overriding common tools #6354

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

kmk3
Copy link
Collaborator

@kmk3 kmk3 commented May 24, 2024

Tools:

  • gzip
  • install
  • rm
  • strip
  • tar

For the programs not checked in configure.ac:

From the manual of GNU Autoconf (version 2.71):

If you use AC_PROG_INSTALL, you must include install-sh in your
distribution

So set install just in the Makefile. Use $(RM) to ensure that -f
is always used and to make it easier to spot when -r is used.

See commit 93d623f ("build: allow overriding certain tools",
2024-02-23) / PR #6222.

This is a follow-up to #6342.

Just in case the value is not defined in config.mk and `make` is first
executed from another directory (such as in src/man) instead of the root
directory.

This amends commit 93d623f ("build: allow overriding certain tools",
2024-02-23) / PR netblue30#6222.
Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmk3 kmk3 force-pushed the build-tool-vars branch from 6184a5c to 9b12a00 Compare May 29, 2024 20:34
Tools:

* gzip
* install
* rm
* strip
* tar

For the programs not checked in configure.ac:

From the manual of GNU Autoconf (version 2.71):

> If you use `AC_PROG_INSTALL`, you must include `install-sh` in your
> distribution

So set `install` just in the Makefile.  Use `$(RM)` to ensure that `-f`
is always used and to make it easier to spot when `-r` is used.

See commit 93d623f ("build: allow overriding certain tools",
2024-02-23) / PR netblue30#6222.
@kmk3 kmk3 force-pushed the build-tool-vars branch from 9b12a00 to fb11081 Compare May 29, 2024 20:37
Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmk3 kmk3 merged commit abc6996 into netblue30:master May 29, 2024
13 checks passed
@kmk3 kmk3 deleted the build-tool-vars branch May 29, 2024 21:27
kmk3 added a commit that referenced this pull request Jun 10, 2024
@kmk3 kmk3 added the enhancement New feature request label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request
Projects
Status: Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

2 participants