-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiles: firefox-common: fix private-etc in includers #6435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glitsj16
approved these changes
Aug 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It was enabled in firefox-common.inc on commit 34d0048 ("private-etc: corss-distro test for curl, gimp, inkscape, firefox, warzone2100", 2023-01-28), but not in the profiles that include it. Enable it in the including profiles as well. Note: This was already done for firefox.profile on commit 7624928 ("firefox: fix private-etc firefox", 2023-06-02) / PR netblue30#5844. Relates to netblue30#6400.
kmk3
force-pushed
the
firefox-common-private-etc
branch
2 times, most recently
from
August 18, 2024 14:39
94df1be
to
c216258
Compare
kmk3
pushed a commit
to celenityy/firejail
that referenced
this pull request
Oct 22, 2024
This fixes access to Thunderbird system policies, which can be set system-wide via `/etc/thunderbird/policies/policies.json`. Users can also use this directory to set different default preferences. Relates to netblue30#6400 netblue30#6435.
kmk3
pushed a commit
that referenced
this pull request
Oct 23, 2024
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Oct 24, 2024
This path is apparently used on Debian. Relates to netblue30#5518 netblue30#6400 netblue30#6435. Reported-by: @Boruch-Baum
kmk3
added a commit
that referenced
this pull request
Oct 25, 2024
This path is apparently used on Debian. Relates to #5518 #6400 #6435. Reported-by: @Boruch-Baum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was enabled in firefox-common.inc on commit 34d0048 ("private-etc:
corss-distro test for curl, gimp, inkscape, firefox, warzone2100",
2023-01-28), but not in the profiles that include it.
Enable it in the including profiles as well.
Note: This was already done for firefox.profile on commit 7624928
("firefox: fix private-etc firefox", 2023-06-02) / PR #5844.
Relates to #6400.