-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New profile: singularity (Endgame: Singularity) #6463
Conversation
Disabled more things in the profile. Does it still work with the changes? |
This is a small python game that does not need any networking or even external access. I already thought what I did was already a bit overkill as my initial profile for this was even smaller. There is simply no attack surface to justify additional effort in my opinion. |
This idea seems backwards. Why give a program more access than it needs, especially if the standard
What would be the additional effort? I mostly just added the rest of the Again, do the changes cause any breakage? |
I do not have any more motivation to test the new directives. I'd prefer to stick to the things I already tested. |
a517517
to
b463983
Compare
All in, thanks! |
By the way, I did briefly test the profile with the hardening changes a while |
Commands used to check for issues: $ git ls-files 'etc/profile-a-l/' | grep 'etc/profile-a-l/[m-z]' etc/profile-a-l/singularity.profile $ git ls-files 'etc/profile-m-z/' | grep 'etc/profile-a-l/[a-l]' $ Command used to fix the path: $ git mv \ etc/profile-a-l/singularity.profile \ etc/profile-m-z/singularity.profile Relates to #6463.
Tested it myself of course. This is a small, python-based game which needs no network access and is generally quite frugal in terms of resources.
I would deem it fine if this is added to firecfg, as there are little to no configurable options and will work out of the box.