New profile: ncmpcpp #6587
Open
New profile: ncmpcpp #6587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmk3
reviewed
Dec 29, 2024
Comment on lines
+27
to
+30
| mkdir ${HOME}/.config/ncmpcpp | ||
| mkdir ${HOME}/.lyrics | ||
| whitelist ${HOME}/.config/ncmpcpp | ||
| whitelist ${HOME}/.lyrics |
There was a problem hiding this comment.
Add these paths to disable-programs.inc and add corresponding noblacklist
entries in this profile.
This should be done whenever adding program-specific paths.
Also, if any of the configuration files allow arbitrary code execution, add
read-only $path to disable-common.inc (and read-write $path to this profile
if the configuration file can be edited by the program itself).
This also applies to the other PRs.
There was a problem hiding this comment.
There are a lot of suggested changes. I will try to apply all changes at once tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ncmpcpp/ncmpcpp
Relates to #6580.