Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: sort.py: quote diff lines #6594

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

kmk3
Copy link
Collaborator

@kmk3 kmk3 commented Dec 29, 2024

To make it clearer when only whitespace was fixed on a given line.

Before:

$ printf 'private-bin a,b \n' >foo.profile
$ ./contrib/sort.py -n foo.profile
sort.py: checking 1 profile(s)...
foo.profile:1:-private-bin a,b
foo.profile:1:+private-bin a,b

After:

$ printf 'private-bin a,b \n' >foo.profile
$ ./contrib/sort.py -n foo.profile
sort.py: checking 1 profile(s)...
foo.profile:1:-'private-bin a,b '
foo.profile:1:+'private-bin a,b'

See commit 53ff8e0 ("build: sort.py: strip trailing whitespace in all
lines", 2024-11-26) / PR #6556.

To make it clearer when only whitespace was fixed on a given line.

Before:

    $ printf 'private-bin a,b \n' >foo.profile
    $ ./contrib/sort.py -n foo.profile
    sort.py: checking 1 profile(s)...
    foo.profile:1:-private-bin a,b
    foo.profile:1:+private-bin a,b

After:

    $ printf 'private-bin a,b \n' >foo.profile
    $ ./contrib/sort.py -n foo.profile
    sort.py: checking 1 profile(s)...
    foo.profile:1:-'private-bin a,b '
    foo.profile:1:+'private-bin a,b'

See commit 53ff8e0 ("build: sort.py: strip trailing whitespace in all
lines", 2024-11-26) / PR netblue30#6556.
@kmk3 kmk3 requested a review from rusty-snake December 29, 2024 07:19
@kmk3 kmk3 merged commit df6620c into netblue30:master Dec 29, 2024
5 checks passed
@kmk3 kmk3 deleted the build-sort-py-quote-diff branch December 29, 2024 12:06
@kmk3 kmk3 added enhancement New feature request modif This modifies existing behavior labels Dec 29, 2024
kmk3 added a commit that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request modif This modifies existing behavior
Projects
Status: Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

2 participants