Feat/packages upgrade #227
Conversation
DCM report❌ Total lint warning issues - 49 Full report: https://github.com/netglade/auto_mappr/runs/35597423040 |
|
Aktualizovat changelog |
| prefer-boolean-prefixes: false # TODO | ||
| avoid-passing-default-values: false # TODO | ||
| avoid-commented-out-code: false # code examples in comments | ||
| prefer-single-declaration-per-file: false # TODO | ||
| prefer-named-parameters: false # TODO |
There was a problem hiding this comment.
Can you rather fix all of these or ignore them in code?
// but yes, we should also add comment or resolve the avoid-non-null-assertion and avoid-nullable-interpolation disabled rules
| @@ -70,6 +70,7 @@ class MapModelBodyMethodBuilder { | |||
| ? mapping.whenSourceIsNullExpression!.returned | |||
| : refer('Exception').newInstance([ | |||
| refer( | |||
| // ignore: avoid-adjacent-strings, to avoid parsing the errors in tests | |||
There was a problem hiding this comment.
The comment does not describe why to ignore it here, no? Also, I would rather fix it here. (aka dont use adjacent strings)
| @@ -193,6 +193,7 @@ class AutoMapprGenerator extends GeneratorForAnnotation<annotation.AutoMappr> { | |||
| ), | |||
| ]; | |||
| }) | |||
| // ignore: avoid-slow-collection-methods, fix dcm without refactoring | |||
There was a problem hiding this comment.
Comment does not make sense, no? This is IMO ok to use here, since we create multiple type mappings from each .map iteration and then we need to flatten it. Maybe this would be OK and faster than this sync* function?
return [
for (item in mappers.map())
...item,
];| prefer-boolean-prefixes: false # TODO | ||
| prefer-named-parameters: false # TODO |
| @@ -2,6 +2,7 @@ import 'package:auto_mappr_annotation/src/field.dart'; | |||
| import 'package:auto_mappr_annotation/src/type_converter.dart'; | |||
|
|
|||
| /// Configured mapping from [SOURCE] to [TARGET]. | |||
| // ignore: avoid-unused-generics, dcm fix without refactoring | |||
There was a problem hiding this comment.
In the comment should be something that we use generics later in code gen.
No description provided.