Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add route names for webhook and preview routes #31

Merged
merged 5 commits into from
Jul 15, 2021
Merged

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jul 15, 2021

This pull adds routes names to the opt-in routes provided by RouteProvider

The primary use case for this is so that you can target these routes more easily when, for example you're applying a CSRF to all post payloads on a website and need to exclude the webhook route from verifying the CSRF.

gsteel added 4 commits July 15, 2021 09:42
Add Integration Test Namespace to autoloader
Add dev dependencies for the config aggregator and laminas service manager
Add the Integration test suite to phpunit config
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #31 (52b93de) into main (a3271b4) will increase coverage by 5.31%.
The diff coverage is 100.00%.

❗ Current head 52b93de differs from pull request most recent head 5e5d49f. Consider uploading reports for the commit 5e5d49f to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main      #31      +/-   ##
============================================
+ Coverage     79.06%   84.37%   +5.31%     
  Complexity      192      192              
============================================
  Files            37       37              
  Lines           511      512       +1     
============================================
+ Hits            404      432      +28     
+ Misses          107       80      -27     
Impacted Files Coverage Δ
src/RouteProvider.php 100.00% <100.00%> (+100.00%) ⬆️
src/ConfigProvider.php 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3271b4...5e5d49f. Read the comment docs.

@gsteel gsteel merged commit 626adcb into main Jul 15, 2021
@gsteel gsteel deleted the add-route-names branch July 15, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant