Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release 1.8.1 into 1.9.x #279

Merged
merged 2 commits into from
May 18, 2023
Merged

Conversation

github-actions[bot]
Copy link
Contributor

Release Notes for 1.8.1

1.8.1

  • Total issues resolved: 0
  • Total pull requests resolved: 1
  • Total contributors: 1

bug

gsteel added 2 commits May 18, 2023 11:51
- Updates the Ref class so that null is allowed for the label
- Marks all `Ref` properties as `public readonly` since we're now on 8.1 minimum
- Marks `Ref` as immutable
- Makes types more precise for `Ref`

Whilst this is possibly a BC break, i.e. the remote API has changed, it could also be due to Scheduled Releases, which may always have carried a null label.

If this turns out to be a fix, then it may need back-porting to older versions
Refs can possibly have null labels
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (350c51c) 97.92% compared to head (2b9fabd) 97.92%.

Additional details and impacted files
@@            Coverage Diff            @@
##              1.9.x     #279   +/-   ##
=========================================
  Coverage     97.92%   97.92%           
- Complexity      670      672    +2     
=========================================
  Files            51       51           
  Lines          1827     1828    +1     
=========================================
+ Hits           1789     1790    +1     
  Misses           38       38           
Impacted Files Coverage Δ
src/Api.php 97.38% <ø> (ø)
src/Value/Ref.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gsteel gsteel self-assigned this May 18, 2023
@gsteel gsteel added the bug Something isn't working label May 18, 2023
@gsteel gsteel added this to the 1.9.0 milestone May 18, 2023
@gsteel gsteel merged commit 63e3518 into 1.9.x May 18, 2023
@gsteel gsteel deleted the 1.8.x-merge-up-into-1.9.x_bCWnoXUx branch May 18, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant