-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename x-deno- to x-nf- #5398
Conversation
📊 Benchmark resultsComparing with 6726bf4 Package size: 267 MB⬇️ 0.00% decrease vs. 6726bf4
|
ab1da2c should've failed some tests 🤔 why is it not? |
it should've failed tests in https://github.com/netlify/cli/blob/main/tests/integration/100.command.dev.test.cjs, but these tests were never executed. It looks like that's because we use Vitest's Here's the imports for the test file that should've been run, but wasn't: cli/tests/integration/100.command.dev.test.cjs Lines 1 to 20 in 2527070
As you can see, there's no import of the source files in there, so Vitest's I'll open a separate issue to track this bug in our CI. Let's go ahead with this PR. |
Part of https://github.com/netlify/partner-deno/issues/11. Renames the
x-deno-
headers tox-nf-
. Will fail right now, but work once netlify/edge-bundler#290 lands.