fix: path imports for typescript #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WHy do you need to remove this? |
|
Oh, I see. What you should insteasd do is leave the imports block and add |
mrstork
force-pushed
the
remove-export-block
branch
from
772743a to
aa0cfc4
Compare
mrstork
changed the title
ascorbic
approved these changes
May 3, 2024
mrstork
pushed a commit
that referenced
this pull request
May 3, 2024
🤖 I have created a release *beep* *boop* --- ## [2.6.2](v2.6.1...v2.6.2) (2024-05-03) ### Bug Fixes * path imports for typescript ([#493](#493)) ([aa417b7](aa417b7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com>
4 tasks
mrstork
added a commit
that referenced
this pull request
May 3, 2024
**Which problem is this pull request solving?** Release failures: https://github.com/netlify/functions/actions/runs/8942002569/job/24563622237 https://github.com/netlify/functions/actions/runs/8939586357/job/24555907790 **List other issues or pull requests related to this problem** See #491, #492, #493 **Checklist** Please add a `x` inside each checkbox: - [x] I have read the [contribution guidelines](../blob/master/CONTRIBUTING.md). - [x] The status checks are successful (continuous integration). Those can be seen below. - [x] Ran `npm run test` which includes `test:publish` and `test:dev` - [x] Tested with `npm link @netlify/functions`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for sending this pull request! 🎉
Please make sure the title is clear and descriptive.
If you are fixing a typo or documentation, please skip these instructions.
Otherwise please fill in the sections below.
Which problem is this pull request solving?
See https://github.com/netlify/functions/actions/runs/8939586357/job/24555907790
Describe the solution you've chosen
Remove export block to support node 10 and allow internal to be imported
Describe alternatives you've considered
Linking
internal.tsinmain.ts, however we look to want to keep these seperateChecklist
Please add a
xinside each checkbox:npm run test:publishnpm link @netlify/functions