Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When serving locally, ignore non-JWT auth headers #108

Merged
merged 1 commit into from
Jan 31, 2019
Merged

When serving locally, ignore non-JWT auth headers #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions lib/serve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,23 @@ function promiseCallback(promise, callback) {
);
}

function buildClientContext(headers) {
// inject a client context based on auth header https://github.com/netlify/netlify-lambda/pull/57
if (!headers['authorization']) return;

const parts = headers['authorization'].split(' ');
if (parts.length !== 2 || parts[0] !== 'Bearer') return;

try {
return {
identity: { url: 'NETLIFY_LAMBDA_LOCALLY_EMULATED_IDENTITY_URL', token: 'NETLIFY_LAMBDA_LOCALLY_EMULATED_IDENTITY_TOKEN' },
user: jwtDecode(parts[1])
};
} catch (e) {
return; // Ignore errors - bearer token is not a JWT, probably not intended for us
}
}

function createHandler(dir, static) {
return function(request, response) {
// handle proxies without path re-writes (http-servr)
Expand Down Expand Up @@ -77,19 +94,8 @@ function createHandler(dir, static) {
};

var callback = createCallback(response);

// inject a client context based on auth header https://github.com/netlify/netlify-lambda/pull/57
let clientContext = {}
if (request.headers['authorization']) {
const parts = request.headers['authorization'].split(' ')
if (parts.length === 2 && parts[0] === 'Bearer') {
clientContext = {
identity: { url: 'NETLIFY_LAMBDA_LOCALLY_EMULATED_IDENTITY_URL', token: 'NETLIFY_LAMBDA_LOCALLY_EMULATED_IDENTITY_TOKEN' },
user: jwtDecode(parts[1])
}
}
}
var promise = handler.handler(lambdaRequest, { clientContext }, callback);

var promise = handler.handler(lambdaRequest, { clientContext: buildClientContext(request.headers) || {} }, callback);
promiseCallback(promise, callback);
};
}
Expand Down