Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable function invocation timeout using Promise.race #116

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

naipath
Copy link
Contributor

@naipath naipath commented Feb 5, 2019

This PR resolves the issue as described in #45 using Promise.race.
Invocation timeout can be configured using the flag -t or --timeout with a default of 10 seconds.

@swyxio
Copy link
Contributor

swyxio commented Feb 6, 2019

fantastic PR @naipath! gonna add some docs and would be happy to release this. any remaining things you wanted to discuss before merge?

@naipath
Copy link
Contributor Author

naipath commented Feb 6, 2019

@sw-yx Happy to help! By all means add some docs and release 👍

@swyxio swyxio mentioned this pull request Feb 11, 2019
@swyxio swyxio merged commit 520b908 into netlify:master Feb 12, 2019
@swyxio
Copy link
Contributor

swyxio commented Feb 12, 2019

@kamal-hossain
Copy link

Hey! I am trying to add set the time out for 30 minutes. So I have added the flag at my package.json file

"scripts": { "lambda-serve": "netlify-lambda serve functions --timeout 1800", },

But is is not working. If you guys kind enough to tell me how to use the --timeout in netlify-lambda then it will be helpful.

@erezrokah
Copy link
Contributor

@kamal-hossain, I would suggest opening a new issue with a reproduction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants