Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package-lock.json to .gitignore #191

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Sep 5, 2019

We can't assume package-lock.json is part of the user/global .gitignore because some libraries push this file to git. So we should add it to .gitignore.

@swyxio swyxio merged commit a82873b into master Sep 5, 2019
@ehmicky ehmicky deleted the refactoring/gitignore-package-lock branch September 5, 2019 17:25
@verythorough
Copy link
Contributor

Is this a special case for package-lock.json in this project? I thought it was typical practice to include the lockfile in git. (npm says it's intended to be, for example.)

@swyxio
Copy link
Contributor

swyxio commented Sep 5, 2019

fair point. theres some community debate and sometimes the diffs are noisy. shrug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants