Support async handlers #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’ve uploaded a small repo that can be used for testing this. |
|
I’ve deployed the test site to Netlify and these are the endpoints: The first one is pretty simple and works, obviously. The other two just respond with a 500, but no error shows in the logs. |
|
Also, I uploaded the promised_land version to Lambda, and it works as expected:
|
|
Awesome, thanks a lot for the changes and the examples @leonardodino and @ThomasEdwards. LGTM! |
|
Cut a new 0.4.0 release including this |
|
Thanks! I've opened a new issue #29 because you still have to return the previous callback contents in the promise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parity with aws async handler support for
netlify-lambda serve.