chore: update tooling #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
added
the
type: chore
erezrokah
force-pushed
the
chore/update_tooling
branch
from
d9608a2 to
f4102ea
Compare
erezrokah
force-pushed
the
chore/update_tooling
branch
from
f4102ea to
4f05353
Compare
BREAKING CHANGE: support for node 8 was dropped
erezrokah
commented
Jul 13, 2020
| jest.mock('fs'); | ||
|
|
||
| describe('config', () => { | ||
| describe('load', () => { |
There was a problem hiding this comment.
Added a test for parsing toml
erezrokah
commented
Jul 13, 2020
| await install.run('.'); | ||
|
|
||
| expect(cp.exec).toHaveBeenCalledTimes(1); | ||
| expect(cp.exec).toHaveBeenCalledWith( |
There was a problem hiding this comment.
Should run npm i on the current directory
erezrokah
commented
Jul 13, 2020
| ); | ||
| }; | ||
| } | ||
|
|
||
| exports.listen = function(port, static, timeout) { | ||
| exports.listen = function (port, isStatic, timeout) { |
There was a problem hiding this comment.
For some reason jest tries to transpile static as a reserved keyword which caused the serve test to fail.
Instead of messing about with jest config files, just renamed the argument.
erezrokah
commented
Jul 13, 2020
| var module = path.join(process.cwd(), dir, chunk); | ||
| delete require.cache[require.resolve(module)]; | ||
| } | ||
| }, | ||
| stopServer: () => server.close(), |
There was a problem hiding this comment.
Exported this to be used in the test
erezrokah
commented
Jul 13, 2020
| "rimraf": "^3.0.2" | ||
| }, | ||
| "engines": { | ||
| "node": ">=8.0.0" | ||
| "node": ">=10.0.0" |
There was a problem hiding this comment.
Breaking change (we need node 10 to update to the latest dependencies).
Since we're planning on doing a major version this should be fine.
ehmicky
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: support for node 8 was dropped
Related to #240