Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): update readme to not include hardcoded version #265

Merged
merged 2 commits into from
Aug 3, 2020
Merged

fix(docs): update readme to not include hardcoded version #265

merged 2 commits into from
Aug 3, 2020

Conversation

erezrokah
Copy link
Contributor

This updates the readme to use the latest version

@erezrokah erezrokah requested a review from ehmicky August 2, 2020 16:05
@erezrokah erezrokah added the type: bug code to address defects in shipped code label Aug 2, 2020
ehmicky
ehmicky approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to remove that code snippet from README? Otherwise this will need to be bumped on each new version?

@erezrokah
Copy link
Contributor Author

Do we want to remove that code snippet from README? Otherwise this will need to be bumped on each new version?

Good point. Since the readme already has this https://github.com/netlify/netlify-lambda#installation I think we can remove it.

@erezrokah erezrokah changed the title fix(docs): use latest version in readme fix(docs): update readme to not include hardcoded version Aug 3, 2020
@erezrokah
Copy link
Contributor Author

@ehmicky fixed

@erezrokah erezrokah merged commit 2ceeca6 into master Aug 3, 2020
@erezrokah erezrokah deleted the fix/docs branch August 3, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmicky ehmicky ehmicky approved these changes

Assignees
No one assigned
Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erezrokah @ehmicky