Support common alternative extensions for entries. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
100% merge this! |
Offirmo
reviewed
Aug 24, 2018
| if (file.match(/\.js$/)) { | ||
| var name = file.replace(/\.js$/, ""); | ||
| if (file.match(/\.(m?js|ts)$/)) { | ||
| var name = file.replace(/\.(m?js|ts)$/, ""); | ||
| webpackConfig.entry[name] = "./" + name; |
There was a problem hiding this comment.
One fix needed: above line should be changed to webpackConfig.entry[name] = "./" + file; since webpack won't pick non-js files by "name", need explicit extension.
|
I would like to see TypeScript support too 👍 |
swyxio
suggested changes
Oct 11, 2018
| if (file.match(/\.js$/)) { | ||
| var name = file.replace(/\.js$/, ""); | ||
| if (file.match(/\.(m?js|ts)$/)) { | ||
| var name = file.replace(/\.(m?js|ts)$/, ""); | ||
| webpackConfig.entry[name] = "./" + name; |
|
I could use this feature, is a merge coming soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for constructing entries from
.js,.mjs, and.tsfiles. For the time being it is still up to users to define loaders and resolution rules for these extensions. It will also be up to users to define typings for TypeScript entries though I may put some in a future PR.