Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc improvements + small updates (webpack 4) #52

Closed
wants to merge 4 commits into from

Conversation

Offirmo
Copy link

@Offirmo Offirmo commented Aug 24, 2018

No description provided.

@swyxio
Copy link
Contributor

swyxio commented Aug 24, 2018

thanks for the PR - we will roll this into #15 soon

swyxio added a commit that referenced this pull request Oct 11, 2018
update readme thanks to #52 suggestions
@swyxio
Copy link
Contributor

swyxio commented Oct 11, 2018

thank you for this Offirmo! pulled your Readme changes here 3209976 and I'm not sure about the node and error message but we can handle that in a separate update if necessary.

closing for now

@swyxio swyxio closed this Oct 11, 2018
@Offirmo
Copy link
Author

Offirmo commented Oct 12, 2018

@sw-yx

  1. the node version was a bother, it should be the most recent stable, it's 100% gain 0% loss here. If AWS supports it, why not using the latest stable?

  2. the error message corresponds to a case I was bitten by. Currently there is no clear message if the build finds no function files. (usually due to a misconfigured directory)

@Offirmo
Copy link
Author

Offirmo commented Oct 12, 2018

@sw-yx P.S. thanks for your awesome work and tool!

@swyxio swyxio reopened this Oct 12, 2018
@stale
Copy link

stale bot commented Jan 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 6, 2019
@swyxio
Copy link
Contributor

swyxio commented Jan 10, 2019

i think we have addressed your concerns here - if any thing else you'd like to see changed please open an issue!

@swyxio swyxio closed this Jan 10, 2019
padipai pushed a commit to padipai/netlify-lambda that referenced this pull request Nov 14, 2019
update readme thanks to netlify/netlify-lambda#52 suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants