-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inject clientContext to served function on dev-server #57
inject clientContext to served function on dev-server #57
Conversation
ref: #51 |
can anyone review this? |
cd4637c
to
705d30e
Compare
hi Joe, i see this but i dont have enough context to approve this or not. tagging @DavidWells on this |
I'm using this now within Netlify and can see OP's reasoning, have added it to 8eecf0d2/netlify-local@6e20738 based on this PR and implementation lines up with Netlify. |
interesting. i have more context now and would like this too. will review in a few days as am ooo right now. feel free to merge if you wish brod |
I just started writing my own take on this PR, only to find out @joe-re beat me to it! I would love to see this merged. An aside: would it be prudent to add something to the docs (and maybe even console.log) that very clearly explain this is not providing true auth? I'm happy to add them myself, but I do not want to slow down this merge request. |
hey @jcolbyfisher i like it too :) merging. can always work on docs later. |
Inject decoded information to served function on dev-server as same as production.
Actually it's difficult to verify access_token, so it's only inject decoded information.
but I think that is enough on development to check Netlify identify roles.