Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inject clientContext to served function on dev-server #57

Merged
merged 2 commits into from
Jan 10, 2019

Conversation

joe-re
Copy link
Contributor

@joe-re joe-re commented Sep 11, 2018

Inject decoded information to served function on dev-server as same as production.
Actually it's difficult to verify access_token, so it's only inject decoded information.
but I think that is enough on development to check Netlify identify roles.

@joe-re
Copy link
Contributor Author

joe-re commented Sep 11, 2018

ref: #51

@joe-re
Copy link
Contributor Author

joe-re commented Sep 22, 2018

can anyone review this?
I feel this is highly needed to develop on local..

@joe-re joe-re force-pushed the inject-client-context-to-dev-server branch from cd4637c to 705d30e Compare September 26, 2018 05:24
@swyxio
Copy link
Contributor

swyxio commented Oct 11, 2018

hi Joe, i see this but i dont have enough context to approve this or not. tagging @DavidWells on this

8eecf0d2 added a commit to 8eecf0d2/netlify-local that referenced this pull request Oct 15, 2018
@8eecf0d2
Copy link
Contributor

I'm using this now within Netlify and can see OP's reasoning, have added it to 8eecf0d2/netlify-local@6e20738 based on this PR and implementation lines up with Netlify.

@swyxio
Copy link
Contributor

swyxio commented Dec 17, 2018

interesting. i have more context now and would like this too. will review in a few days as am ooo right now. feel free to merge if you wish brod

@jcolbyfisher
Copy link
Contributor

I just started writing my own take on this PR, only to find out @joe-re beat me to it! I would love to see this merged.

An aside: would it be prudent to add something to the docs (and maybe even console.log) that very clearly explain this is not providing true auth? I'm happy to add them myself, but I do not want to slow down this merge request.

@swyxio
Copy link
Contributor

swyxio commented Jan 10, 2019

hey @jcolbyfisher i like it too :) merging. can always work on docs later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants