-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate #606
chore: deprecate #606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danez Thanks for the review request! Nothing major but I left a few suggestions for smoothing out the flow and cleaning up the spelling and grammar so I'm requesting changes.
One thing I suggested in a couple places is removing the word "simply". This well-intentioned word can backfire and make people who find the directions confusing feel even worse about being confused. In general it's better to convey the simplicity of instructions by making the instructions themselves simple to follow rather than telling people explicitly that the process is simple.
Co-authored-by: Kristen Lavavej <[email protected]>
Thanks for the detailed review. I applied all the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danez - I see one suggestion that wasn't committed (the suggestion to remove the pop culture reference from the README). I assume this was an accident since your last comment said you applied all the suggested changes, but please let me know if you skipped that one on purpose.
I'm re-upping that suggestion to remove the pop culture reference but otherwise this looks good to me - thanks for applying my suggestions ✨
Co-authored-by: Kristen Lavavej <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that last change @danez !
Fixes: https://github.com/netlify/pod-compute/issues/55
After this I will be releasing one more patch version with all the security updates.