Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate #606

Merged
merged 4 commits into from
Feb 15, 2023
Merged

chore: deprecate #606

merged 4 commits into from
Feb 15, 2023

Conversation

danez
Copy link
Contributor

@danez danez commented Aug 1, 2022

Fixes: https://github.com/netlify/pod-compute/issues/55

  • Remove renovate
  • Remove label workflow
  • Remove foss workflow
  • Revert webpack5 upgrade from renovate (why did it do a major update anyway)
  • Change README.md message about deprecation
  • Add MIGRATE.md

After this I will be releasing one more patch version with all the security updates.

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Aug 1, 2022
@danez danez changed the title chore chore: deprecate Feb 13, 2023
@danez danez removed the type: chore work needed to keep the product and development running smoothly label Feb 13, 2023
@danez danez self-assigned this Feb 13, 2023
@danez danez marked this pull request as ready for review February 13, 2023 12:12
This was referenced Feb 13, 2023
Copy link
Contributor

@klavavej klavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danez Thanks for the review request! Nothing major but I left a few suggestions for smoothing out the flow and cleaning up the spelling and grammar so I'm requesting changes.

One thing I suggested in a couple places is removing the word "simply". This well-intentioned word can backfire and make people who find the directions confusing feel even worse about being confused. In general it's better to convey the simplicity of instructions by making the instructions themselves simple to follow rather than telling people explicitly that the process is simple.

MIGRATE.md Outdated Show resolved Hide resolved
MIGRATE.md Outdated Show resolved Hide resolved
MIGRATE.md Outdated Show resolved Hide resolved
MIGRATE.md Outdated Show resolved Hide resolved
MIGRATE.md Outdated Show resolved Hide resolved
MIGRATE.md Outdated Show resolved Hide resolved
MIGRATE.md Outdated Show resolved Hide resolved
MIGRATE.md Outdated Show resolved Hide resolved
MIGRATE.md Show resolved Hide resolved
MIGRATE.md Outdated Show resolved Hide resolved
@danez
Copy link
Contributor Author

danez commented Feb 14, 2023

Thanks for the detailed review. I applied all the changes.

@danez danez requested a review from klavavej February 14, 2023 09:51
klavavej
klavavej previously approved these changes Feb 14, 2023
Copy link
Contributor

@klavavej klavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danez - I see one suggestion that wasn't committed (the suggestion to remove the pop culture reference from the README). I assume this was an accident since your last comment said you applied all the suggested changes, but please let me know if you skipped that one on purpose.

I'm re-upping that suggestion to remove the pop culture reference but otherwise this looks good to me - thanks for applying my suggestions ✨

README.md Outdated Show resolved Hide resolved
Co-authored-by: Kristen Lavavej <[email protected]>
Copy link
Contributor

@klavavej klavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that last change @danez !

@danez danez merged commit cf8cacf into main Feb 15, 2023
@danez danez deleted the migrate branch February 15, 2023 15:16
@danez danez mentioned this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants