Removed base-64 package in favour of node Buffer

[8eecf0d2]

I haven't read much about the base-64 package but it's usage in netlify-lambda must be incorrect or not doing what's expected.

Switched to node Buffer instead and afaict it should be doing the same thing, but for whatever reason Buffer works and base-64 doesn't 🤷‍♂️

#26

[swyxio]

thanks Brod. will circulate for review here

[bcomnes]

lgtm, but I don't have the bandwidth to test this at the moment. @sw-yx do you have time to test?

[8eecf0d2]

I'm also a bit lost regarding this feature..

As far as responses, the following should return a png to the browser - changing isBase64Encoded to false should return the base64 string.

import * as fs from "fs";

export const handler = async (request, context, callback) => {

  const pngBuffer = fs.readFileSync("image.png");
  
  return callback(null, {
    statusCode: 200,
    body: pngBuffer.toString("base64"),
    isBase64Encoded: true,
  })
}

As far as request's go, Netlify Functions docs mentions:

{
  ...
  "isBase64Encoded": "A boolean flag to indicate if the applicable request payload is Base64-encode"
}

Which I'm guessing from the previous implementation worked correctly(?) although I have no means to test it right now.

[bcomnes]

cc @biilmann any insight on whats going on here?

[swyxio]

accepting as it seems to be the better way but not sure if it's actually fixing #26 .