-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge current build context environment vars for lambda build #89
Conversation
Might be worth splitting out to a context merging method to set all options (not just environment) with support for branch specific contexts and the special context Based on docs, given the following config and run within a git branch called [build]
publish = "/default"
[build.environment]
SOME_VAR = true
[context.branch-deploy]
publish = "/branch-deploy"
[context.branch-deploy.environment]
SOME_VAR = false
[context.foo-branch]
publish = "/foo-branch"
[context.foo-branch.environment]
SOME_OTHER_VAR = 10 We should end up with: {
"build": {
"publish": "/foo-branch",
"environment": {
"SOME_VAR": false,
"SOME_OTHER_VAR": 10,
}
}
} |
sorry for late response - i was on holiday - i see theres also some desire to use the BRANCH env var: #59 (comment) - but i dont see that as a blocker to merge this. up to your discretion on this one @8eecf0d2, i dont feel too strongly about it |
i've updated this to use the branch config |
awesome - ive been wondering about tests too and should probably get that going at some point. just wasnt built into it from the start. |
I've added some tests as well as a travis yml in #94 |
wow! nice! very kind of you! unfortunately i'm not an owner of the netlify org so i have to request permission to add travis - just requested it but no guarantees |
This is included in #94 |
resolves #59