Added support find usages for PHP classes in neon #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mesour
commented
Jan 4, 2020
•
mesour
commented
- Added support find usages for PHP classes used in neon
- Added inspections for used undefined classes
- Increased minimum compatibility with PHPStorm 2018.3
mesour
force-pushed
the
mn-php-classes-usages
branch
from
559775b to
d5a9174
Compare
matej21
reviewed
Jan 5, 2020
| @@ -28,8 +31,25 @@ public String getValueText() { | |||
| return text; | |||
| } | |||
|
|
|||
| public boolean isPhpScalar() { | |||
There was a problem hiding this comment.
neslo by to dat do interface? abys nemusel mit instanceof NeonScalarImpl?
matej21
reviewed
Jan 5, 2020
| return NeonPhpUtil.isReferenceFor(className, ((PhpClass) element)); | ||
| } | ||
|
|
||
| } |
…d improved more in completion configuration keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.