Also build on windows #166
Conversation
normanmaurer
force-pushed
the
windows
branch
5 times, most recently
from
d013d9c to
212f325
Compare
Motivation: We should also build on windows our native bits. Modifications: - Add jobs to build on windows - Adjust build config to support windows Result: Verify we can build on windows
| <AdditionalDependencies>ws2_32.lib;crypt32.lib;userenv.lib;@BORINGSSL_LIB_DIR@\@SSL_LIB@;@BORINGSSL_LIB_DIR@\@CRYPTO_LIB@;@QUICHE_LIB_DIR@\@QUICHE_LIB@;%(AdditionalDependencies)</AdditionalDependencies> | ||
| </Link> | ||
| </ItemDefinitionGroup> | ||
| </Project> |
There was a problem hiding this comment.
maybe need is a bit strong word here ... But yeah we can add one
| <customPackageDirectory>${templateDir}</customPackageDirectory> | ||
| <windowsBuildTool>msbuild</windowsBuildTool> | ||
| <windowsCustomProps>true</windowsCustomProps> | ||
| <windowsPlatformToolset>v140</windowsPlatformToolset> |
There was a problem hiding this comment.
Can we use v142 (the latest one)?
There was a problem hiding this comment.
Can you explain why v140 is not good enough ? I am not very into development on windows ;)
There was a problem hiding this comment.
I always prefer the latest VS libraries to avoid conflicts in various Windows 10 releases. So v142 is the latest one right now. Just a suggestion. :D
There was a problem hiding this comment.
will this also work on windows server 2008 for example ?
There was a problem hiding this comment.
If correct libraries are installed then it'll.
I can test compatibility on old systems if you want,
There was a problem hiding this comment.
that would be amazing.
There was a problem hiding this comment.
Windows Server 2008 R2 EOL January 2020. I will test on Windows Server 2012 R2 with the latest snapshot available.
There was a problem hiding this comment.
Sorry for the late reply. It works fine on Windows Server 2012 R2. Cheers! :D
There was a problem hiding this comment.
if you are interested please submit a pr.
Motivation:
We should also build on windows our native bits.
Modifications:
Add jobs to build on windows
Result:
Verify we can build on windows