Fix flaky test in URLNormalizerTest.java #1419
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test below in
URLNormalizerTest.java
was found flaky because of the ordering of result String. The orders of elements in the String are not the same every time being called. In this case, two possible outputs of the String are applied to ensure the orders do not cause the flakiness. This code change is trying to fix the flaky tests mentioned above, because they sometimes fail (as the picture showed) and sometimes pass. The failure could be reproduced by the commands above by using the tool of NonDex. The code change is to make sure the tests will always pass in this case.com.networknt.url.URLNormalizerTest.testAllAtOnce
The test failures could be reproduced by
mvn install -pl http-url -am -DskipTests
mvn -pl http-url edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=com.networknt.url.URLNormalizerTest#testAllAtOnce