Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #2265 SidecarPathPrefixServiceHandler never calls put attachment #2266

Merged
merged 2 commits into from
Jun 24, 2024
Merged

fixes #2265 SidecarPathPrefixServiceHandler never calls put attachment #2266

merged 2 commits into from
Jun 24, 2024

Conversation

stevehu
Copy link
Contributor

@stevehu stevehu commented Jun 24, 2024

No description provided.

@stevehu stevehu requested a review from DiogoFKT June 24, 2024 19:47
DiogoFKT
DiogoFKT reviewed Jun 24, 2024
View reviewed changes
Copy link
Contributor

@DiogoFKT DiogoFKT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to have HandlerUtils.findServiceEntry(HandlerUtils.normalisePath(requestPath), config.getMapping())[0] instead of Constants.UNKOWN_STRING right?

@DiogoFKT
Copy link
Contributor

Looks good!

@stevehu stevehu merged commit 68c1324 into master Jun 24, 2024
1 check passed
@stevehu stevehu deleted the issue2265 branch June 24, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiogoFKT DiogoFKT DiogoFKT left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevehu @DiogoFKT