Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for namespaces #126

Open
denis-tingaikin opened this issue May 10, 2022 · 5 comments
Open

Add support for namespaces #126

denis-tingaikin opened this issue May 10, 2022 · 5 comments
Assignees
@NikitaSkrynnik

Comments

@denis-tingaikin
Copy link
Member

denis-tingaikin commented May 10, 2022 •
edited
Loading

Description

Since NSM is able to provide vl3 networks, it could be useful to add support for labled namespaces. All pods within the labled namespace could be handled by the webhook that injects nsm client based on the NSM label in each POD.
@denis-tingaikin
Copy link
Member Author

@edwarnicke I think this could be an inresting one for v1.5.0

@edwarnicke
Copy link
Member

@denis-tingaikin Could you say more? :)

@denis-tingaikin
Copy link
Member Author

denis-tingaikin commented May 10, 2022 •
edited
Loading

@edwarnicke Sure.

Use-case

  1. The k8s admin deploys a namespace:
kind: Namespace
apiVersion: v1
metadata:
  name: test
  labels:
    "networkservicemesh.io": "kernel://my-vl3-network"
  1. k8s admin deploy a pod into that namespace (note the pod doesnt have nsm annotation)
  2. the pod is handled by the admission webhook
  3. the pod got vl3 network from NSM via injected NSC

Makes sense?

@edwarnicke
Copy link
Member

@denis-tingaikin Would this be labels or annotations?

@denis-tingaikin
Copy link
Member Author

@edwarnicke

It will be an annotation.

This was referenced Aug 12, 2022
Merged
Merged
nsmbot pushed a commit that referenced this issue Jan 18, 2024
Sync files with networkservicemesh/cmd-template
1a5a4ce 
This PR syncs files with https://github.com/networkservicemesh/cmd-template

Revision: https://github.com/networkservicemesh/cmd-template/commits/8b3ce39b8f3cbfec1f1e1ce445893118f514d0ee

commit 8b3ce39b8f3cbfec1f1e1ce445893118f514d0ee
Author: Nikita Skrynnik <[email protected]>
Date:   Thu Jan 18 19:54:16 2024 +1100

    Update Spire and Delve in Dockerfile (#126)

    Signed-off-by: Nikita Skrynnik <[email protected]>

Signed-off-by: NSMBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikitaSkrynnik NikitaSkrynnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@edwarnicke @denis-tingaikin @NikitaSkrynnik