Add an option to change reselect function #1585

NikitaSkrynnik · 2024-02-12T09:07:45Z

Description

Add an ability to change connection modifications during a reselect, because vl3 healing should not delete NSE name

Issue link

networkservicemesh/cmd-nse-vl3-vpp#289

How Has This Been Tested?

Added unit testing to cover
Tested manually
Tested by integration testing
Have not tested

Types of changes

codecov · 2024-02-29T09:18:32Z

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@608b1b5). Click here to learn what that means.

❗ Current head dbf3870 differs from pull request most recent head abc0fc4. Consider uploading reports for the commit abc0fc4 to get more accurate results

Files	Patch %	Lines
pkg/networkservice/common/begin/options.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1585   +/-   ##
=======================================
  Coverage        ?   67.27%           
=======================================
  Files           ?      262           
  Lines           ?    12464           
  Branches        ?        0           
=======================================
  Hits            ?     8385           
  Misses          ?     3554           
  Partials        ?      525

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

glazychev-art

Can we add a test with a custom ReselectFunc?

denis-tingaikin · 2024-09-23T14:21:05Z

As I can see, CI failed 12 times in a row; it looks like we have problems with these changes.

pkg/networkservice/common/begin/event_factory.go

pkg/networkservice/common/heal/options.go

pkg/networkservice/chains/client/options.go

pkg/networkservice/chains/nsmgr/heal_test.go

Signed-off-by: NikitaSkrynnik <[email protected]>

…k-vpp@main PR link: networkservicemesh/sdk-vpp#870 Commit: d063ab3 Author: Network Service Mesh Bot Date: 2024-11-26 03:13:04 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#870) PR link: networkservicemesh/sdk-kernel#697 Commit: 89a3b43 Author: Network Service Mesh Bot Date: 2024-11-26 03:08:35 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#697) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]>

…k-k8s@main (#470) PR link: networkservicemesh/sdk-k8s#535 Commit: 7cdc892 Author: Network Service Mesh Bot Date: 2024-11-26 03:12:31 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#535) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…k-vpp@main (#717) PR link: networkservicemesh/sdk-vpp#870 Commit: d063ab3 Author: Network Service Mesh Bot Date: 2024-11-26 03:13:04 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#870) PR link: networkservicemesh/sdk-kernel#697 Commit: 89a3b43 Author: Network Service Mesh Bot Date: 2024-11-26 03:08:35 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#697) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…d-admission-webhook-k8s@main PR link: networkservicemesh/cmd-admission-webhook-k8s#470 Commit: 0bcb54b Author: Network Service Mesh Bot Date: 2024-11-26 03:24:39 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#470) PR link: networkservicemesh/sdk-k8s#535 Commit: 7cdc892 Author: Network Service Mesh Bot Date: 2024-11-26 03:12:31 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#535) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]>

…k-vpp@main (#285) PR link: networkservicemesh/sdk-vpp#870 Commit: d063ab3 Author: Network Service Mesh Bot Date: 2024-11-26 03:13:04 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#870) PR link: networkservicemesh/sdk-kernel#697 Commit: 89a3b43 Author: Network Service Mesh Bot Date: 2024-11-26 03:08:35 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#697) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…d-nse-icmp-responder-vpp@main PR link: networkservicemesh/cmd-nse-icmp-responder-vpp#717 Commit: c3bb31a Author: Network Service Mesh Bot Date: 2024-11-26 03:25:13 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#717) PR link: networkservicemesh/sdk-vpp#870 Commit: d063ab3 Author: Network Service Mesh Bot Date: 2024-11-26 03:13:04 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#870) PR link: networkservicemesh/sdk-kernel#697 Commit: 89a3b43 Author: Network Service Mesh Bot Date: 2024-11-26 03:08:35 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#697) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]>

…k-k8s@main (#438) PR link: networkservicemesh/sdk-k8s#535 Commit: 7cdc892 Author: Network Service Mesh Bot Date: 2024-11-26 03:12:31 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#535) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…k-k8s@main (#363) PR link: networkservicemesh/sdk-k8s#535 Commit: 7cdc892 Author: Network Service Mesh Bot Date: 2024-11-26 03:12:31 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#535) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…d-nse-simple-vl3-docker@main PR link: networkservicemesh/cmd-nse-simple-vl3-docker#285 Commit: 2ce76c0 Author: Network Service Mesh Bot Date: 2024-11-26 03:25:34 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#285) PR link: networkservicemesh/sdk-vpp#870 Commit: d063ab3 Author: Network Service Mesh Bot Date: 2024-11-26 03:13:04 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#870) PR link: networkservicemesh/sdk-kernel#697 Commit: 89a3b43 Author: Network Service Mesh Bot Date: 2024-11-26 03:08:35 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#697) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]>

…k-vpp@main (#270) PR link: networkservicemesh/sdk-vpp#870 Commit: d063ab3 Author: Network Service Mesh Bot Date: 2024-11-26 03:13:04 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#870) PR link: networkservicemesh/sdk-kernel#697 Commit: 89a3b43 Author: Network Service Mesh Bot Date: 2024-11-26 03:08:35 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#697) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…d-nse-supplier-k8s@main PR link: networkservicemesh/cmd-nse-supplier-k8s#363 Commit: bc95e96 Author: Network Service Mesh Bot Date: 2024-11-26 03:26:09 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#363) PR link: networkservicemesh/sdk-k8s#535 Commit: 7cdc892 Author: Network Service Mesh Bot Date: 2024-11-26 03:12:31 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#535) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]>

…k-vpp@main (#536) PR link: networkservicemesh/sdk-vpp#870 Commit: d063ab3 Author: Network Service Mesh Bot Date: 2024-11-26 03:13:04 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#870) PR link: networkservicemesh/sdk-kernel#697 Commit: 89a3b43 Author: Network Service Mesh Bot Date: 2024-11-26 03:08:35 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#697) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…d-forwarder-ovs@main PR link: networkservicemesh/cmd-forwarder-ovs#438 Commit: 45a00e1 Author: Network Service Mesh Bot Date: 2024-11-26 03:25:53 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#438) PR link: networkservicemesh/sdk-k8s#535 Commit: 7cdc892 Author: Network Service Mesh Bot Date: 2024-11-26 03:12:31 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#535) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]>

…d-nse-vlan-vpp@main PR link: networkservicemesh/cmd-nse-vlan-vpp#536 Commit: a40bc31 Author: Network Service Mesh Bot Date: 2024-11-26 03:26:40 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#536) PR link: networkservicemesh/sdk-vpp#870 Commit: d063ab3 Author: Network Service Mesh Bot Date: 2024-11-26 03:13:04 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#870) PR link: networkservicemesh/sdk-kernel#697 Commit: 89a3b43 Author: Network Service Mesh Bot Date: 2024-11-26 03:08:35 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#697) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]>

…d-admission-webhook-k8s@main (#12561) PR link: networkservicemesh/cmd-admission-webhook-k8s#470 Commit: 0bcb54b Author: Network Service Mesh Bot Date: 2024-11-26 03:24:39 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#470) PR link: networkservicemesh/sdk-k8s#535 Commit: 7cdc892 Author: Network Service Mesh Bot Date: 2024-11-26 03:12:31 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#535) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…d-nse-vlan-vpp@main (#12564) PR link: networkservicemesh/cmd-nse-vlan-vpp#536 Commit: a40bc31 Author: Network Service Mesh Bot Date: 2024-11-26 03:26:40 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#536) PR link: networkservicemesh/sdk-vpp#870 Commit: d063ab3 Author: Network Service Mesh Bot Date: 2024-11-26 03:13:04 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#870) PR link: networkservicemesh/sdk-kernel#697 Commit: 89a3b43 Author: Network Service Mesh Bot Date: 2024-11-26 03:08:35 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#697) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…k-vpp@main (#381) PR link: networkservicemesh/sdk-vpp#870 Commit: d063ab3 Author: Network Service Mesh Bot Date: 2024-11-26 03:13:04 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#870) PR link: networkservicemesh/sdk-kernel#697 Commit: 89a3b43 Author: Network Service Mesh Bot Date: 2024-11-26 03:08:35 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#697) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…d-nsc-simple-docker@main PR link: networkservicemesh/cmd-nsc-simple-docker#270 Commit: fd1e303 Author: Network Service Mesh Bot Date: 2024-11-26 03:26:22 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#270) PR link: networkservicemesh/sdk-vpp#870 Commit: d063ab3 Author: Network Service Mesh Bot Date: 2024-11-26 03:13:04 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#870) PR link: networkservicemesh/sdk-kernel#697 Commit: 89a3b43 Author: Network Service Mesh Bot Date: 2024-11-26 03:08:35 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#697) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]>

…d-nse-vl3-vpp@main PR link: networkservicemesh/cmd-nse-vl3-vpp#381 Commit: 13839be Author: Network Service Mesh Bot Date: 2024-11-26 03:29:07 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#381) PR link: networkservicemesh/sdk-vpp#870 Commit: d063ab3 Author: Network Service Mesh Bot Date: 2024-11-26 03:13:04 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#870) PR link: networkservicemesh/sdk-kernel#697 Commit: 89a3b43 Author: Network Service Mesh Bot Date: 2024-11-26 03:08:35 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#697) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]>

NikitaSkrynnik requested review from glazychev-art and denis-tingaikin March 1, 2024 04:38

glazychev-art reviewed Mar 26, 2024

View reviewed changes

NikitaSkrynnik force-pushed the vl3-healing branch from dbf3870 to abc0fc4 Compare April 19, 2024 06:03

NikitaSkrynnik force-pushed the vl3-healing branch from abc0fc4 to e4bfbef Compare August 16, 2024 00:59

NikitaSkrynnik force-pushed the vl3-healing branch from e4bfbef to 6d27917 Compare September 23, 2024 05:38

NikitaSkrynnik force-pushed the vl3-healing branch 2 times, most recently from d05a912 to 445fe1e Compare September 30, 2024 07:57

denis-tingaikin reviewed Oct 10, 2024

View reviewed changes

pkg/networkservice/common/begin/event_factory.go Outdated Show resolved Hide resolved

pkg/networkservice/common/heal/options.go Outdated Show resolved Hide resolved

NikitaSkrynnik force-pushed the vl3-healing branch 5 times, most recently from 64f7064 to faf8151 Compare October 11, 2024 06:36

NikitaSkrynnik force-pushed the vl3-healing branch from faf8151 to 372da31 Compare November 6, 2024 08:49

denis-tingaikin reviewed Nov 11, 2024

View reviewed changes

pkg/networkservice/chains/client/options.go Outdated Show resolved Hide resolved

pkg/networkservice/chains/nsmgr/heal_test.go Outdated Show resolved Hide resolved

NikitaSkrynnik force-pushed the vl3-healing branch from da53f35 to 13adb29 Compare November 12, 2024 05:12

NikitaSkrynnik added 11 commits November 20, 2024 17:15

Add mutable reselect function

560d198

Signed-off-by: NikitaSkrynnik <[email protected]>

fix go linter issues

ae04e6c

Signed-off-by: NikitaSkrynnik <[email protected]>

add a test with custom reselect function

9940ec0

Signed-off-by: NikitaSkrynnik <[email protected]>

revert changes in liveness check ctx

39fc856

Signed-off-by: NikitaSkrynnik <[email protected]>

pass reselectFunc through client

58b07df

Signed-off-by: NikitaSkrynnik <[email protected]>

cleanup

71f8950

Signed-off-by: NikitaSkrynnik <[email protected]>

fix linter issues

46acee0

Signed-off-by: NikitaSkrynnik <[email protected]>

fix linter issues

66cfe7b

Signed-off-by: NikitaSkrynnik <[email protected]>

fix test

4d27d06

Signed-off-by: NikitaSkrynnik <[email protected]>

Fix review comments

3bd6399

Signed-off-by: NikitaSkrynnik <[email protected]>

fix CI issues

83805ba

Signed-off-by: NikitaSkrynnik <[email protected]>

nsmbot mentioned this pull request Nov 26, 2024

Update from update/networkservicemesh/cmd-admission-webhook-k8s networkservicemesh/deployments-k8s#12561

Merged

nsmbot mentioned this pull request Nov 26, 2024

Update from update/networkservicemesh/cmd-nse-icmp-responder-vpp networkservicemesh/deployments-k8s#12562

Merged

nsmbot mentioned this pull request Nov 26, 2024

Update from update/networkservicemesh/cmd-forwarder-ovs networkservicemesh/deployments-k8s#12563

Merged

nsmbot mentioned this pull request Nov 26, 2024

Update from update/networkservicemesh/cmd-nse-vlan-vpp networkservicemesh/deployments-k8s#12564

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add an option to change reselect function #1585

Add an option to change reselect function #1585

NikitaSkrynnik commented Feb 12, 2024 •

edited

Loading

codecov bot commented Feb 29, 2024 •

edited

Loading

glazychev-art left a comment

denis-tingaikin commented Sep 23, 2024

Add an option to change reselect function #1585

Add an option to change reselect function #1585

Conversation

NikitaSkrynnik commented Feb 12, 2024 • edited Loading

Description

Issue link

How Has This Been Tested?

Types of changes

codecov bot commented Feb 29, 2024 • edited Loading

Codecov Report

glazychev-art left a comment

Choose a reason for hiding this comment

denis-tingaikin commented Sep 23, 2024

NikitaSkrynnik commented Feb 12, 2024 •

edited

Loading

codecov bot commented Feb 29, 2024 •

edited

Loading