Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignoring functions in utils for the get_info dict #78

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Ignoring functions in utils for the get_info dict #78

merged 1 commit into from
Aug 21, 2024

Conversation

Schefflera-Arboricola
Copy link
Member

@Schefflera-Arboricola Schefflera-Arboricola mentioned this pull request Aug 20, 2024
Merged
dschult
dschult approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

It means we only include get_info information for functions outside of the utils subpackage. If that kind of restriction becomes troublesome later we can implement a more precise method to exclude functions from the dict.

Thanks!

@dschult dschult merged commit a98224c into networkx:main Aug 21, 2024
12 of 13 checks passed
@jarrodmillman jarrodmillman added this to the 0.3 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschult dschult dschult approved these changes

Assignees
No one assigned
Labels
type: Bug fix Something isn't working type: Maintenance
Milestone
0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Schefflera-Arboricola @dschult @jarrodmillman