Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev:console command outputs "must be compatible with" error #901

Closed
markshust opened this issue Dec 21, 2021 · 4 comments
Closed

dev:console command outputs "must be compatible with" error #901

markshust opened this issue Dec 21, 2021 · 4 comments
Labels

Comments

@markshust
Copy link
Contributor

markshust commented Dec 21, 2021

Describe the bug

Running n98-magerun2 dev:console produces the following error:

n98-magerun2 dev:console

Fatal error: Declaration of N98\Magento\Command\Developer\Console\Shell::run(?Symfony\Component\Console\Input\InputInterface $input = NULL, ?Symfony\Component\Console\Output\OutputInterface $output = NULL) must be compatible with Psy\Shell::run(?Symfony\Component\Console\Input\InputInterface $input = NULL, ?Symfony\Component\Console\Output\OutputInterface $output = NULL): int in phar:///var/www/html/bin/n98-magerun2.phar/src/N98/Magento/Command/Developer/Console/Shell.php on line 41

Expected behaviour

Drops into dev console without error.

Steps to reproduce the issue

Install docker-magento project and run bin/devconsole (which is a shortcut for bin/n98-magerun2, which runs this script in the Docker container).

Technical details

MacOS w/Docker Desktop, Magento 2.4.3-p1, PHP 7.4.26, n98-magerun2 4.9.0

@markshust markshust added the bug label Dec 21, 2021
markshust added a commit to markshust/n98-magerun2 that referenced this issue Dec 21, 2021
@markshust
Copy link
Contributor Author

See related PR. I'm not sure how to test these updates locally, but the PR should update the script so the function sig matches the parent function sig.

@cmuench
Copy link
Member

cmuench commented Dec 22, 2021

@markshust Thanks for reporting. Seems that we need a automated test here. I will release a hotfix.

cmuench pushed a commit that referenced this issue Dec 22, 2021
@cmuench
Copy link
Member

cmuench commented Dec 22, 2021

@markshust Released as v4.9.1. We had to fight with the recent Composer 2.2 release first.

@cmuench cmuench closed this as completed Dec 22, 2021
@cmuench
Copy link
Member

cmuench commented Jan 9, 2022

@markshust for documentation. The automated test of this command is now in the functional test suite. See MR #922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants