Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to create a github release #1281

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

cmuench
Copy link
Member

@cmuench cmuench commented Sep 1, 2023

Changes proposed in this pull request:

  • Remove separate release workflow file
  • Add new job in release workflow which creates a github release with attached n98-magerun2.phar and gpg sign file.

@cmuench cmuench added this to the 7.2.0 milestone Sep 1, 2023
@cmuench
Copy link
Member Author

cmuench commented Sep 1, 2023

Related to #1098

@drupol I changed the release workflow to Github Actions to provide more tranparency.
The new workflow will publish the phar file to files.magerun.net and additionally as Github Release.
The updater of n98-magerun will still use the files.magerun.net site to download updates.
If someone want to use Github as download resource, it's then possible.

@cmuench cmuench merged commit da10b91 into netz98:develop Sep 1, 2023
@drupol
Copy link

drupol commented Sep 2, 2023

Amazing stuff ! Thank you very much for this, I'll update the packages in nixpkgs in the upcoming days.

Why did you suddenly change your mind about it ?

@cmuench
Copy link
Member Author

cmuench commented Sep 2, 2023

@drupol I thought it's important to increase the "truck count".
I am the only guy who understands the deployment.
Transparency of an open source project is also important.

@cmuench
Copy link
Member Author

cmuench commented Sep 2, 2023

@drupol If you change the nix package... Please orient on the last release 7.1.0.
The package will always contain a n98-magerun2.phar and a n98-magerun2.phar.asc with the detached GPG Signaturen.

I also attached the corresponding phar files to older release. Older releases have the tag in the phar. That will not be happen for upcoming releases.

drupol added a commit to NixOS/nixpkgs that referenced this pull request Sep 2, 2023
Also:
- update `src` and minor refactor
- Context: netz98/n98-magerun2#1281
@drupol
Copy link

drupol commented Sep 2, 2023

Cool !

Created the PR: NixOS/nixpkgs#252905

@drupol
Copy link

drupol commented Sep 2, 2023

Done. I've updated both n98-magerun and n98-magerun2, now using Github as primary source.

I noticed that there's a difference in the URL pattern between the two, I've adapted the code. If by any chance you could align both pattern, ping me, and I'll do the changes in nixpkgs.

@cmuench
Copy link
Member Author

cmuench commented Sep 2, 2023

@drupol The latest release was wrong for n98-magerun (v1).
This is now the latest release: https://github.com/netz98/n98-magerun/releases/tag/2.3.0

I was able to change the file name as well.

drupol added a commit to NixOS/nixpkgs that referenced this pull request Sep 2, 2023
@drupol drupol mentioned this pull request Sep 2, 2023
12 tasks
@drupol
Copy link

drupol commented Sep 2, 2023

Done, I just pushed the PR to change the URL. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants