Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bittensor-version-update #251

Merged
merged 10 commits into from
Jan 22, 2025
Merged

Bittensor-version-update #251

merged 10 commits into from
Jan 22, 2025

Conversation

mo0haned
Copy link
Collaborator

No description provided.

@purshottam-sharma
Copy link
Collaborator

@mo0haned Pls fix the merge conflicts. Also going forward please follow the git branch naming convention.

@purshottam-sharma
Copy link
Collaborator

@nauttiilus Please review and merge to dev we need this feature for v1.8.0

@purshottam-sharma
Copy link
Collaborator

purshottam-sharma commented Jan 21, 2025

@mo0haned Kindly plesae resolve all the merge conflicts so that @nauttiilus can review and merge.

Also could you plesae confirm if the "bittensor-version-update" is created from dev.

compute/__init__.py Fixed Show fixed Hide fixed
compute/__init__.py Fixed Show fixed Hide fixed
@@ -21,10 +21,11 @@
import bittensor.utils.networking as net

import compute
import inspect

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'inspect' is not used.
Removed redundant assignments for `pog_retry_limit` and `pog_retry_interval`.
Copy link
Collaborator

@nauttiilus nauttiilus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated your branch:
Fix: Removed duplicate variable definitions.
Eliminated redundant assignments for pog_retry_limit and pog_retry_interval.
I left the unused inspect import as I'm unsure of its intended use—it might be needed in the future.
Everything else looks good, but I haven't tested it.

@nauttiilus nauttiilus merged commit b288c43 into dev Jan 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants