fix: restore default docs URL in FastAPI initialization #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mo0haned Hope you are doing well. Please make sure to create branches based on the SOP document circulated. Also kindly plesae assign a reviewer. |
|
One suggestion. If we already add the IP checking in the APP middleware (added by Eduardo) and have the certificate to protect the access to the API who owns the certificate, how about we only keep the below line since enabling trace or not has no meaning now (both of them will enable the default /docs viewpoint on FastAPI. self.app = FastAPI(debug=False) |
|
I agree. this was just a quick edit for the new guys to test the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.