Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/v1.7.4 #258

Merged
merged 10 commits into from
Jan 22, 2025
Merged

Release/v1.7.4 #258

merged 10 commits into from
Jan 22, 2025

Conversation

nauttiilus
Copy link
Collaborator

  • Fixes: Resolves the low vtrust issue for some validators.
  • Features: Introduces WandB logging for PgG stats.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 21, 2025
View reviewed changes
compute/wandb/wandb.py
import hashlib
import json

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'json' is not used.
compute/wandb/wandb.py
bt.logging.info(f"Run ID: {run.id}, Name: {run.name}, Error: {e}")

# Helper function: pick the single "dominant" dict from valid_entries
def pick_dominant_dict(valid_entries):

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
neurons/register_api.py
from ipwhois import IPWhois
import threading
import time
import asyncio

Check notice

Code scanning / CodeQL

Module is imported more than once Note

This import of module asyncio is redundant, as it was previously imported
on line 30
Loading
.
neurons/register_api.py
import random
from concurrent.futures import ThreadPoolExecutor

from neurons.Validator.database.pog import get_pog_specs

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'get_pog_specs' is not used.
neurons/register_api.py
@@ -2744,7 +2786,7 @@

return {"status": False, "msg": "Requested resource is not available."}

def _allocate_container_hotkey(self, requirements, hotkey, timeline, public_key, docker_requirement: dict):
async def _allocate_container_hotkey(self, requirements, hotkey, timeline, public_key, docker_requirement: dict):

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
neurons/register_api.py
if register_response and register_response["status"] is False:

response = await self._notify_allocation_status(

Check warning

Code scanning / CodeQL

Variable defined multiple times Warning

This assignment to 'response' is unnecessary as it is
redefined
Loading
before this value is used.
This assignment to 'response' is unnecessary as it is
redefined
Loading
before this value is used.
This assignment to 'response' is unnecessary as it is
redefined
Loading
before this value is used.
neurons/register_api.py
finally:
cursor.close()

def get_hotkey_lock(self, hotkey):

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
neurons/validator.py
Comment on lines +625 to +633
# for hotkey, specs in specs_dict.values():
# gpu_info = specs.get("gpu", {})
# gpu_details = gpu_info.get("details", [])
# if gpu_details:
# gpu_name = gpu_details[0].get("name", "Unknown GPU")
# gpu_count = gpu_info.get("count", 1) # Assuming 'count' reflects the number of GPUs
# bt.logging.info(f"{hotkey}: {gpu_name} x {gpu_count}")
# else:
# bt.logging.info(f"{hotkey}: No GPU details available")

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
scripts/opencompute/server.py
@@ -142,7 +142,7 @@
hardware_specs_cache = await loop.run_in_executor(executor, fetch_hardware_specs, api, hotkeys)
allocated_hotkeys_cache = await loop.run_in_executor(executor, get_allocated_hotkeys, api)
#penalized_hotkeys_cache = await loop.run_in_executor(executor, get_penalized_hotkeys, api)
penalized_hotkeys_cache = await loop.run_in_executor(executor, get_penalized_hotkeys_id, api, "neuralinternet/opencompute/dvgtj3dr")
penalized_hotkeys_cache = await loop.run_in_executor(executor, get_penalized_hotkeys_id, api, "neuralinternet/opencompute/0djlnjjs")

Check notice

Code scanning / CodeQL

Unused global variable Note

The global variable 'penalized_hotkeys_cache' is not used.
@purshottam-sharma
Copy link
Collaborator

@nauttiilus
I hope you're doing well. I was reviewing the PR and I had a quick question regarding the creation of the release/v1.7.4 branch. Could you kindly clarify whether this branch was created from dev or another branch?
I appreciate your assistance in helping me understand the process better. Thank you in advance!

@nauttiilus nauttiilus requested review from mo0haned and removed request for mo0haned January 22, 2025 15:55
@nauttiilus nauttiilus merged commit 7c3ccf2 into main Jan 22, 2025
2 checks passed
nauttiilus added a commit that referenced this pull request Jan 27, 2025
@nauttiilus
Merge pull request #264 from neuralinternet/main
68505c8 
Merge pull request #258 from neuralinternet/release/v1.7.4
@mo0haned mo0haned deleted the release/v1.7.4 branch February 5, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nauttiilus @purshottam-sharma