fix: correct commitlint config file name typo #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanAnishchuk
requested changes
Feb 3, 2025
There was a problem hiding this comment.
The fix is correct according to documentation. But why fix config without enabling CI check? I believe that's the guide https://commitlint.js.org/guides/ci-setup
IvanAnishchuk
force-pushed
the
bugfix/CSN-506-Correct-commitlint-config-file-name-typo
branch
from
6386fd3 to
e7b9d0a
Compare
Enable commitlint action.
IvanAnishchuk
force-pushed
the
bugfix/CSN-506-Correct-commitlint-config-file-name-typo
branch
from
e7b9d0a to
93ba035
Compare
|
Suggested config was a little outdated, fixed that. Please confirm I didn't break anything and re-request review. |
So that it's consistent between CI workflow and local pre-commit run.
mo0haned
approved these changes
Feb 4, 2025
IvanAnishchuk
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correct commitlint config file name typo
commitlint-config.js->commitlint.config.jshttps://github.com/conventional-changelog/commitlint