Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return-the-miner-version-on-the-Allocation-request #275

Conversation

mo0haned
Copy link
Collaborator

No description provided.

@thomas-chu123
Copy link
Collaborator

I have no concern from the code point of view, is there any linked Jira URL for this new feature? Is there any reason we must provide the miner version info during the allocation action?

@thomas-chu123
Copy link
Collaborator

I have cherry picked the change and merged it with release/1.8.0 and the allocation did show the miner version.

@mo0haned
Copy link
Collaborator Author

mo0haned commented Feb 3, 2025

You are right. this isn't tracked on Jira. it was based on a conversation on Slack. I created the ticket CZN-571 for this.

@purshottam-sharma
Copy link
Collaborator

@thomas-chu123 Currently, the dashboard calls the check miner function once an hour to retrieve the version. Mohaned raised a valid point: if an allocation happens just after the cron job runs, it will take up to an hour for the user to see the 'SSH' button in the browser. By including the miner version in the allocation process, users will be able to see the button immediately after the allocation.

@thomas-chu123
Copy link
Collaborator

So, the dashboard will adopt PR#275 rather than PR#280 since the miner check function endpoint will not be used.

@mo0haned
Copy link
Collaborator Author

mo0haned commented Feb 3, 2025

both will be used. this one will be used as an immediate response. but in the future, we might make an update and we need to check the miners who are already allocated. for that, we should use the check miner status endpoint

@thomas-chu123 thomas-chu123 merged commit dfebbb0 into release/v1.8.0 Feb 3, 2025
mo0haned pushed a commit that referenced this pull request Feb 3, 2025
…on-the-Allocation-request

Return-the-miner-version-on-the-Allocation-request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants