Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CSN-567): On allocation return miner version from axon info #287

Merged

Conversation

mo0haned
Copy link
Collaborator

@mo0haned mo0haned commented Feb 3, 2025

  • remove the miner version retrival from miner side.
  • replace with miner version retrival from the Axon info

@IvanAnishchuk
Copy link
Collaborator

@mo0haned please fix PR title, we are starting to use conventional commits format for this

@mo0haned mo0haned changed the title Csn-567-on-allocation-return-miner-version-from-axon-info Fix(csn-567): on allocation return miner version from axon info Feb 3, 2025
@mo0haned mo0haned changed the title Fix(csn-567): on allocation return miner version from axon info fix(csn-567): on allocation return miner version from axon info Feb 3, 2025
@mo0haned
Copy link
Collaborator Author

mo0haned commented Feb 3, 2025

Fixed.

@IvanAnishchuk IvanAnishchuk changed the title fix(csn-567): on allocation return miner version from axon info fix(CSN-567): On allocation return miner version from axon info Feb 3, 2025
Copy link
Collaborator

@IvanAnishchuk IvanAnishchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approved

@mo0haned
Copy link
Collaborator Author

mo0haned commented Feb 3, 2025

Thank you. merging to dev now

@mo0haned mo0haned merged commit 3d54a96 into dev Feb 3, 2025
2 checks passed
@mo0haned mo0haned deleted the csn-567-on-allocation-return-miner-version-from-axon-info branch February 5, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants