Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated deployment of Docker image used to build the wheels #2678

Closed
JCGoran opened this issue Jan 18, 2024 · 1 comment · Fixed by #2688
Closed

Automated deployment of Docker image used to build the wheels #2678

JCGoran opened this issue Jan 18, 2024 · 1 comment · Fixed by #2688
Assignees
Labels
building Issue related to build/compilation CI Continuous Integration enhancement

Comments

@JCGoran
Copy link
Contributor

JCGoran commented Jan 18, 2024

Follow up on #2669.

The neuronsimulator/neuron_wheel Docker images, which are used for building the NEURON wheels, are currently built and uploaded to DockerHub manually. It would be nice to instead have a (possibly manually triggered) GitHub action or similar which can deploy all of the necessary images automatically.

@JCGoran JCGoran added enhancement CI Continuous Integration building Issue related to build/compilation labels Jan 18, 2024
@heerener
Copy link
Collaborator

Github released an M1 runner in October 2023, but it's only available as an xlarge runner which is not free. According to actions/runner-images#8439 (comment) they're planning on making smaller runners available for free for public projects, but there's no news on when exactly this will happen so far ("after GA, which should be Jan-Mar 2024").

Fortunately we have an in-house M1 runner attached to our gitlab instance. It even has docker installed, but the daemon is not running. I've launched the discussion about starting it, from there we can see about building

@heerener heerener self-assigned this Jan 23, 2024
@JCGoran JCGoran linked a pull request Jan 30, 2024 that will close this issue
pramodk pushed a commit that referenced this issue Feb 8, 2024
* Issue #2678: add container build job on gitlab

* Update documentation for the automated docker build
* A manual action to build the wheels container for x86_64
* Make specifying the tag through a variable mandatory
   As a consequence, only run on manually-triggered pipelines
* document which variables need to be set when starting the podman
  machine on the m1 runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Issue related to build/compilation CI Continuous Integration enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants