ECG peak detection Zong (2003): reimplement

[DominiqueMakowski]

Our implementation of this peak detection method is tagged as not really working.

NeuroKit/neurokit2/ecg/ecg_findpeaks.py

Lines 446 to 448 in 277f614

	"""
	# TODO: Doesn't really seems to work

py-ecg-detectors has a another implementation: we should probably reimplement ours based on that.

[Yashaswini278]

Hi, could you assign this to me? I'm new to contributing to open source and have some experience in working with ECG data (currently working on an internship in Griffith University to develop an AI-enabled framework for continuous
monitoring fetal well-being using abdominal ECG signal in order to provide more timely interventions.)

[DominiqueMakowski]

Hi @Yashaswini278, thanks for volunteering! but actually I think we just recently did it in #663, but feel free to give it a look and double-check whether everything looks in order (it's currently on the dev branch) :)

[Yashaswini278]

Oh, sure, thanks! Would love to contribute in other ecg related issues! :)

[DominiqueMakowski]

Will keep that in mind! Are you interested mostly in ECG signal processing (e.g., peak detection) or more like feature extraction (e.g., HRV etc)?

[Yashaswini278]

I've mostly worked on peak detection, and using deep learning techniques for abdominal ECG denoising, to obtain fetal ECG. But i'm willing to explore further and work on feature extraction as well!

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.