Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Zong (2003) ECG peak detection method #663

Merged
merged 8 commits into from
Jul 9, 2022

Conversation

anshu-97
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022

Codecov Report

Merging #663 (811c3da) into dev (773d748) will decrease coverage by 0.19%.
The diff coverage is 14.81%.

@@            Coverage Diff             @@
##              dev     #663      +/-   ##
==========================================
- Coverage   53.21%   53.02%   -0.20%     
==========================================
  Files         269      270       +1     
  Lines       12112    12222     +110     
==========================================
+ Hits         6446     6481      +35     
- Misses       5666     5741      +75     
Impacted Files Coverage Δ
neurokit2/ecg/ecg_peaks.py 100.00% <ø> (ø)
neurokit2/ecg/ecg_findpeaks.py 73.18% <14.81%> (-2.74%) ⬇️
neurokit2/rsp/rsp_simulate.py 94.64% <0.00%> (-3.58%) ⬇️
neurokit2/epochs/epochs_create.py 81.48% <0.00%> (-3.14%) ⬇️
neurokit2/data/read_bitalino.py 8.90% <0.00%> (-0.36%) ⬇️
neurokit2/hrv/hrv_nonlinear.py 65.09% <0.00%> (ø)
neurokit2/events/events_find.py 80.95% <0.00%> (ø)
neurokit2/complexity/__init__.py 100.00% <0.00%> (ø)
neurokit2/signal/signal_filter.py 64.89% <0.00%> (ø)
neurokit2/complexity/fractal_dfa.py 60.78% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 773d748...811c3da. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jun 29, 2022
@DominiqueMakowski DominiqueMakowski changed the title [Fix] ECG peak detection method [Feature] Add Zong (2003) ECG peak detection method Jul 9, 2022
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 9, 2022
@DominiqueMakowski DominiqueMakowski merged commit df03f1b into dev Jul 9, 2022
@DominiqueMakowski DominiqueMakowski deleted the fix-ecg-peakdetector branch July 9, 2022 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants