-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] add min, max, 80th & 20th percentiles as HRV features #627
[Feature] add min, max, 80th & 20th percentiles as HRV features #627
Conversation
Thanks for opening this pull request! We'll make sure it's perfect before merging 🤗 |
neurokit2/hrv/hrv_time.py
Outdated
@@ -50,8 +50,12 @@ def hrv_time(peaks, sampling_rate=1000, show=False, **kwargs): | |||
- **HCVNN**: The median absolute deviation of the RR intervals (MadNN) divided by the median | |||
of the absolute differences of their successive differences (MedianNN). | |||
- **IQRNN**: The interquartile range (IQR) of the RR intervals. | |||
- **Prc20NN**: The 20th percentile of the RR intervals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danibene Great, thanks, very clean PR :)
It's mostly good, but could you perhaps add one or two references in which they use these indices? You can add the full ref in the Reference section and the short form (refauthor, 1998) after the index (in the future we could probably add that to all of the indices but that will be WIP)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :)
I added two references for each but please feel free to add/remove/edit.
Also, consider adding yourself to the contributor list if you want |
Codecov Report
@@ Coverage Diff @@
## dev #627 +/- ##
==========================================
+ Coverage 82.54% 82.62% +0.07%
==========================================
Files 235 235
Lines 11276 11289 +13
==========================================
+ Hits 9308 9327 +19
+ Misses 1968 1962 -6
Continue to review full report at Codecov.
|
Looks great, thanks again @danibene !! will merge as soon as the checks pass |
Add the minimum, maximum, 20th percentile, and 80th percentile NN as features in the hrv_time function.