-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] ECG inversion #716
Conversation
Codecov ReportBase: 52.72% // Head: 52.76% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #716 +/- ##
==========================================
+ Coverage 52.72% 52.76% +0.03%
==========================================
Files 279 280 +1
Lines 12643 12672 +29
==========================================
+ Hits 6666 6686 +20
- Misses 5977 5986 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nevermind just realized that this would add an additional dependency, not worth the time saved I assume
I streamlined the example a bit and added a (Also, note that I added some
After the plots: the reason for this is that basically, when sphinxruns the documentation and runs ipython on the example chuncks, it will create matplotlib figures. But it doesn't close them automatically, meaning that after 20 opened images it will error and say that there are too many images concurrently opened (and the documentation build will fail). So we need to close the plots that we create in the docstrings manually; and the |
@DominiqueMakowski this all looks good to me, I'll go ahead and merge! |
Description
This PR aims at adding the ability to identify and correct ECG signal inversion. See also #558
Proposed Changes
I added the
ecg_invert()
function so that a user could optionally correct for signal inversion in the raw ECG data before using the other processing functions (cleaning, peak detection).Checklist
Here are some things to check before creating the PR. If you encounter any issues, do let us know :)