[Fix] interpolate signal with only one value #787
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Interpolating a single value currently raises an error, causing tests here to fail, and I know this has also previously been an issue #740
Proposed Changes
I changed the
signal_interpolate()
function so that it returns a constant signal if only one x value is provided rather than raising an error.We could alternatively check the length of the input to
signal_interpolate()
inrsp_rvt()
where it is currently causing the error. But unless we can think of a situation in which a constant signal is not the desired output given only one x value, I feel like directly modifyingsignal_interpolate()
makes more sense than checking the length of the input whereversignal_interpolate()
is used?Checklist
Here are some things to check before creating the PR. If you encounter any issues, do let us know :)