Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] prevent deprecation warning in signal_interpolate() #816

Conversation

danibene
Copy link
Collaborator

Description

This PR aims to prevent the following warning when running signal_interpolate():
DeprecationWarning: elementwise comparison failed; this will raise an error in the future.

Proposed Changes

I changed the signal_interpolate() function so that a line (that I think I added, by the way, sorry) using np.all now uses np.array_equal instead:
https://stackoverflow.com/questions/44574679/python-deprecationwarning-elementwise-comparison-failed-this-will-raise-an

Checklist

Here are some things to check before creating the PR. If you encounter any issues, do let us know :)

  • I have read the CONTRIBUTING file.
  • My PR is targetted at the dev branch (and not towards the master branch).

prevent following warning

DeprecationWarning: elementwise comparison failed; this will raise an error in the future.
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (3d5ecfc) 53.82% compared to head (fae8a3e) 53.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #816      +/-   ##
==========================================
- Coverage   53.82%   53.81%   -0.01%     
==========================================
  Files         295      295              
  Lines       13799    13799              
==========================================
- Hits         7427     7426       -1     
- Misses       6372     6373       +1     
Impacted Files Coverage Δ
neurokit2/signal/signal_interpolate.py 63.04% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DominiqueMakowski DominiqueMakowski merged commit b92e1fb into neuropsychology:dev Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants