Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ecg_process.py #836

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

BeardedBioelectronics
Copy link
Contributor

Fixed typo re: ECG peak info dict key

Description
This PR is just a basic typo fix in the comments and a test run before more significant contributions.

Proposed Changes
I changed a comment to accurately describe the key used for ECG Peaks in info

Checklist
Here are some things to check before creating the PR. If you encounter any issues, do let us know :)

[X ] I have read the CONTRIBUTING file.
[ X] My PR is targetted at the dev branch (and not towards the master branch).
[ N/A] I ran the CODE CHECKS on the files I added or modified and fixed the errors.
[ N/A] I have added the newly added features to News.rst (if applicable)

Fixed typo re: ECG peak info dict key
@welcome
Copy link

welcome bot commented Jun 1, 2023

Thanks for opening this pull request! We'll make sure it's perfect before merging 🤗 force
Make sure to read the contributing guide. Also, if you think that your contribution is worthy of it, you can consider adding yourself to the Contributors list (feel free to ask us if you have any doubts).

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (690eac7) 53.83% compared to head (ee7079f) 53.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #836      +/-   ##
==========================================
+ Coverage   53.83%   53.87%   +0.04%     
==========================================
  Files         295      295              
  Lines       13802    13802              
==========================================
+ Hits         7430     7436       +6     
+ Misses       6372     6366       -6     
Impacted Files Coverage Δ
neurokit2/ecg/ecg_process.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danibene danibene self-requested a review June 1, 2023 14:22
Copy link
Collaborator

@danibene danibene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you for the fix 😃

@danibene danibene merged commit 3cf70af into neuropsychology:dev Jun 1, 2023
@welcome
Copy link

welcome bot commented Jun 1, 2023

landing
Congrats on merging your first pull request! 🎉🍾 We're looking forward to your next one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants