ECG: Corrected Error in basSQI calculation #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from Zhao and Zhang's paper (https://www.ncbi.nlm.nih.gov/pmc/articles/PMC6011094/#B11) in figure 11 the the basSQI should be (1-∫p(t)) / ∫p(t). I therefore changed the _ecg_quality_basSQI function return from "return (1 - num_power) / dem_power" to "return (1 - num_power) / dem_power"
|
Thanks for opening this pull request! We'll make sure it's perfect before merging 🤗 |
DominiqueMakowski
changed the title
|
Nice catch @Jacob-Liam-Albaugh , and welcome to GitHub |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
from Zhao and Zhang's paper (https://www.ncbi.nlm.nih.gov/pmc/articles/PMC6011094/#B11) in figure 11
Proposed Changes
the the basSQI should be (1-∫p(t)) / ∫p(t). I therefore changed the _ecg_quality_basSQI function return from "return (1 - num_power) / dem_power" to "return (1 - num_power) / dem_power"