-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] EMG report #841
[Feature] EMG report #841
Conversation
local variable 'index' referenced before assignment
I think the test for emg_plot is currently failing because I returned a figure even when it is generated with matplotlib to keep the option of generating a report with matplotlib instead of plotly |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #841 +/- ##
==========================================
+ Coverage 53.88% 55.23% +1.35%
==========================================
Files 295 296 +1
Lines 13811 13905 +94
==========================================
+ Hits 7442 7681 +239
+ Misses 6369 6224 -145
☔ View full report in Codecov by Sentry. |
can we merge that? |
Description
This PR aims to generate an interactive HTML report describing EMG processing as described in #665
Proposed Changes
emg_plot()
function so that it optionally generates an interactive plot with plotlyemg_methods()
functionemg_process()
function so that it optionally generates a reportreport.py
to reference EMG; however, I did not add any EMG-specific logic for generating a summary table. I wonder if we should usebio_analyze()
to generate the table rather than checking the column names withinreport.py
Checklist