[FIX] KeyError in _eventrelated_addinfo #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See neuropsychology#867 (comment) _eventrelated_addinfo in epochs/eventrelated_utils.py has these lines: ``` if "Index" in epoch.columns: output["Event_Onset"] = epoch.loc[np.min(np.abs(epoch.index))]["Index"] ``` np.min(np.abs(...) returns the smallest absolute time offset in seconds. If the smallest absolute value is of a negative time offset, then it produces a non-existent index, causing an error when indexing in epoch.loc. This commit replaces it with iloc[np.argmin(np.abs(...))], indexing by integer index.
|
Thanks for opening this pull request! We'll make sure it's perfect before merging 🤗 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #868 +/- ##
==========================================
- Coverage 55.28% 55.23% -0.06%
==========================================
Files 297 297
Lines 13918 13918
==========================================
- Hits 7695 7688 -7
- Misses 6223 6230 +7
☔ View full report in Codecov by Sentry. |
|
Nice catch @SimonLafran thanks |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #867
_eventrelated_addinfoin epochs/eventrelated_utils.py has these lines:np.min(np.abs(...))returns the smallest absolute time offset in seconds. If the smallest absolute value is of a negative time offset, then it produces a non-existent index, causing an error when indexing in epoch.loc.This commit replaces it with
iloc[np.argmin(np.abs(...))], indexing by integer index.