Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] update docs to reflect implementation of respiration signal cleaning with khodadad2018 #952

Merged

Conversation

danibene
Copy link
Collaborator

Description

See #950 (comment).

Proposed Changes

  1. I changed the docstring of the rsp_clean() function so that it describes the filter used.
  2. I changed rsp_methods() so that the information for the processing report also describes the filter used.

Checklist

Here are some things to check before creating the PR. If you encounter any issues, do let us know :)

  • I have read the CONTRIBUTING file.
  • My PR is targeted at the dev branch (and not towards the master branch).
  • I ran the CODE CHECKS on the files I added or modified and fixed the errors.
  • I have added the newly added features to News.rst (if applicable)

@DominiqueMakowski DominiqueMakowski merged commit ba9b3a3 into neuropsychology:dev Jan 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants